[POS Orders] Handle filtering for POS orders #15886

iamgabrielma · 2025-07-09T07:06:45Z

Description

This PR adds the sales channel filter to the order list with 2 options: Point of Sale, and Any. The sales channel filter should work like any other filters in the app, examples:

Selecting POS orders should show only POS orders
Selecting ANY should show any order
POS filter in combination with other filters should show the expected results (ie: with "order status cancelled + POS" = No results if you have none of the sort)

Screen.Recording.2025-07-09.at.14.00.20.mov

Changes

Rather than declaring a specific view controller for sales channels, I've used the existing static design introduced on Filter Products screen #2204. This automatically handles simple lists like the one we need here, without having to customize further.
Updated OrdersRemote when fetching all orders, as well as OrderAction to pass the created_via property on synchronizeOrders and fetchFilteredOrders. I've discovered too late that core data query is not enough for filtering, while the correct filter was being passed locally, we need to perform a network request when filtering, which should have the &created_via=pos-rest-api param along it.
Adjusted the tests to the updated signatures (no new tests have been added yet)

Testing information

In a site eligible for POS, and WooCommerce 9.9+, you should see your recent orders marked with a POS badge. If you have none, please go through the POS flow and checkout a few.
Navigate to orders tab, tap in Filters, observe the Sales channel filter is now functional.
Select "Point of sale" as an option. Observe that POS orders are listed, while others are hidden.
Try different filtering combinations.
Clear all should clear all filters
Filter persistence is not implemented yet, so the sales channel filter won't be saved between runs.

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…tom case handling

wpmobilebot · 2025-07-09T07:16:03Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr15886-21203bc`
	Version	`22.7`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`21203bc`
	Installation URL	2r8ksd641ovf8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

joshheald

Works as expected... consider if we need some tests, but otherwise this can be merged.

Various questions inline, mostly prompted by the PR but out of its scope...

Also – there's a discrepency between salesChannel in the app, and created_via from the API... which is totally fine, this is a better description. Just be as sure as you can that we're safe for any future changes – I could see us adding sales_channel or some other channel in the API, and needing to move to that. After all, couldn't you theoretically create a POS order via the store-api, rather than the rest-api in future?

I think it'll be fine, but just have a think 😊

joshheald · 2025-07-10T06:17:53Z

WooCommerce/WooCommerceTests/ViewRelated/Orders/Filters/FilterOrderListViewModelTests.swift

                                                       customer: CustomerFilter(customer: Customer.fake().copy(customerID: 1)),
-                                                       salesChannel: nil,
-                                                       numberOfActiveFilters: 4)
+                                                       salesChannel: .any,


In practice, any is kind of like a nil filter, right? Should we use POS here instead?

Very true, updated on e28ac77 , as well as other existing tests on 21203bc

joshheald · 2025-07-10T06:23:18Z

...ce/WooCommerceTests/ViewRelated/Dashboard/Orders/LastOrdersDashboardCardViewModelTests.swift

Not for this PR, but a product question; should we add the badge or an option to filter to the LastOrdersDashboardCard? Status is the only filter shown and supported right now, but given badge display and how close the two badges are in the list UI, it may be expected.

For people using the card, I can see clear benefits – e.g. if you use the most recent orders card to check whether you have any unfulfilled orders, POS orders are only ever in the way of you seeing that, because they're always fulfilled. 3 finished POS orders at the top of the list may make you think everything's processed, but be hiding a pending order further down the list.

That's a very good point, I didn't though about these possibilities until was forced to update the fetching method for other views. I'll check with Sam and raise this for the next milestones.

joshheald · 2025-07-10T07:02:04Z

WooCommerce/Classes/ViewRelated/Orders/OrderListViewModel.swift

+            case .pointOfSale:
+                let predicate = NSPredicate(format: "createdVia == %@", "pos-rest-api")
+                return predicate
+            case .any:
+                return nil


Using it, I immediately felt that there should be a web option.

Other options I've seen in the backend are checkout and rest-api – presumably there are more. checkout came from both the block and classic checkouts, but I did see store_api for a draft order – it got changed to checkout when the order was paid for though.

I don't know how much you've discussed it... even though the fix is out of scope of this PR, it feels wrong from a user perspective right now. Selecting "not POS" would be fine but isn't possible right now, as far as I can see.

I don't think it was discussed at the time, but agree: Currently wp-admin already shows a sales channel filter within orders for All Sales Channels, Admin, Checkout, and Point of Sale. So we should do the same in-app

iamgabrielma · 2025-07-14T05:40:47Z

Thanks for the review!

there's a discrepency between salesChannel in the app, and created_via from the API... which is totally fine, this is a better description. Just be as sure as you can that we're safe for any future changes – I could see us adding sales_channel or some other channel in the API, and needing to move to that. After all, couldn't you theoretically create a POS order via the store-api, rather than the rest-api in future?

Yes, I think we could map and centralize these directly in Networking to some sort of SalesChannel enum, or perhaps update the field in the Order model so we parse it directly to closer terms to the ones we use in the app. I assumed that we do not want to touch the actual API, but perhaps that's a good approach as well. I've experimented a bit with it but I was forced to import NetworkingCore into WooCommerce, I'll have to take a better look into it separately. Logged in WOOMOB-848 👍

iamgabrielma added 2 commits July 9, 2025 12:20

create filter by using existing .staticOptions design rather than cus…

be286c4

…tom case handling

Update remotes to fetch filtered by created_via

92b306e

iamgabrielma added feature: order list Related to the order list. feature: POS labels Jul 9, 2025

iamgabrielma modified the milestones: 22.9, 22.8 Jul 9, 2025

iamgabrielma added 5 commits July 9, 2025 15:13

restore updating selected value action only when value changes

f65e26f

make test target compile

e7c7675

fix tests due initial values

eae19c2

update localized strings

f5d1728

fix numberOfActiveFilters in test

de893f4

iamgabrielma marked this pull request as ready for review July 9, 2025 09:40

iamgabrielma requested a review from joshheald July 9, 2025 10:06

joshheald self-assigned this Jul 10, 2025

joshheald approved these changes Jul 10, 2025

View reviewed changes

iamgabrielma modified the milestones: 22.8, 22.9 Jul 11, 2025

iamgabrielma added 2 commits July 14, 2025 12:03

update test filter criteria

e28ac77

update existing tests with saleschannel filter

21203bc

iamgabrielma merged commit 34c8ee4 into trunk Jul 14, 2025
13 checks passed

iamgabrielma deleted the task/WOOMOB-711-make-view-for-sales-channel-filter branch July 14, 2025 05:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POS Orders] Handle filtering for POS orders #15886

[POS Orders] Handle filtering for POS orders #15886

Uh oh!

iamgabrielma commented Jul 9, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 9, 2025 •

edited

Loading

Uh oh!

joshheald left a comment

Uh oh!

joshheald Jul 10, 2025

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

joshheald Jul 10, 2025

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

joshheald Jul 10, 2025

Uh oh!

iamgabrielma Jul 14, 2025

Uh oh!

iamgabrielma commented Jul 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[POS Orders] Handle filtering for POS orders #15886

[POS Orders] Handle filtering for POS orders #15886

Uh oh!

Conversation

iamgabrielma commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing information

Uh oh!

wpmobilebot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshheald left a comment

Choose a reason for hiding this comment

Uh oh!

joshheald Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

joshheald Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

joshheald Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma commented Jul 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iamgabrielma commented Jul 9, 2025 •

edited

Loading

wpmobilebot commented Jul 9, 2025 •

edited

Loading